Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle missing VideoRangeType in stream tracks #853

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

oddstr13
Copy link
Member

@oddstr13 oddstr13 commented Apr 9, 2024

Fixes #849

hdrtype is defaulted to empty string just below, but do tell if you think it should be handled explicitly.

Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 21.50%. Comparing base (309e108) to head (bc8cae9).
Report is 7 commits behind head on master.

Files Patch % Lines
jellyfin_kodi/helper/api.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   21.49%   21.50%           
=======================================
  Files          63       63           
  Lines        8625     8623    -2     
  Branches     1588     1587    -1     
=======================================
  Hits         1854     1854           
+ Misses       6747     6745    -2     
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcarlton00 mcarlton00 merged commit b585377 into jellyfin:master Apr 9, 2024
10 of 11 checks passed
@oddstr13 oddstr13 added the bugfix label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync Failed
2 participants